Re: [PATCH v4 4/5] Add reftable library
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Feb 18, 2020, 09:25 UTC
- Message-ID
- <CAFQ2z_OGU_X1Mu=kzd6tdDGtYGEXzTHz+AzrK+KAuQx7ZPZ8qg@mail.gmail.com>
- In-Reply-To
- <20200211234000.GA6464@camp.crustytoothpaste.net>
On Wed, Feb 12, 2020 at 12:40 AM brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 14 quoted lines
> > On 2020-02-11 at 16:40:56, Han-Wen Nienhuys wrote: > > I can see a future where we have a different format that allows for > > more metadata so we can encode the hash size separately. But maybe > > that can be for format v3 and up. > > > > Let's do format v2 = format v1 but with 32-byte hashes. > > The way we've preferred to do this in Git is to write a four-byte hash > identifier into the file, but we have legacy concerns here, so I think > switching to v2 for SHA-256 is fine. > -- > brian m. carlson: Houston, Texas, US > OpenPGP: https://keybase.io/bk2204
I've implemented this in the last version of the series.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado