Re: [PATCH v6 0/5] Reftable support git-core
- From
Han-Wen Nienhuys <hanwenn@gmail.com>
- Date
- Feb 19, 2020, 16:59 UTC
- Message-ID
- <CAOw_e7abpAwTkb6qKZjbxxw7XrAWdhcANbjAWvRxi1_fT5vSDA@mail.gmail.com>
- In-Reply-To
- <xmqqy2szip35.fsf@gitster-ct.c.googlers.com>
On Tue, Feb 18, 2020 at 10:05 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> > Here is what I got from "git am --whitespace=fix" on these five patches. > Does it match your test application? > > Applying: refs.h: clarify reflog iteration order > Applying: create .git/refs in files-backend.c > Applying: refs: document how ref_iterator_advance_fn should handle symrefs > .git/rebase-apply/patch:145: trailing whitespace. > > .git/rebase-apply/patch:147: trailing whitespace. > > .git/rebase-apply/patch:6544: indent with spaces. > left = *destLen; > .git/rebase-apply/patch:6545: indent with spaces. > *destLen = 0; > .git/rebase-apply/patch:6548: indent with spaces. > left = 1; > warning: squelched 15 whitespace errors
your checker is tripping over code imported from zlib. I added a /* clang-format off */ comment to avoid reformatting this code. What do you suggest?
-- Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen