Re: [PATCH v2 5/5] Reftable support for git-core
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Jan 29, 2020, 18:53 UTC
- Message-ID
- <CAFQ2z_P2Xu5iEj0ixnM=ZjrH2++dJHWu9znJj0g8csEj2COpeA@mail.gmail.com>
- In-Reply-To
- <xmqqh80e5cjk.fsf@gitster-ct.c.googlers.com>
On Wed, Jan 29, 2020 at 7:43 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> > Jeff King <peff@peff.net> writes: > > > Making "refs" a file instead of a directory does work nicely, as any > > attempts to read or write would get ENOTDIR. And we can fool > > is_git_directory() as long as it's marked executable. That's OK on POSIX > > systems, but I'm not sure how it would work on Windows (or maybe it > > would work just fine, since we presumably just say "yep, everything is > > executable"). > > > > So perhaps that's enough, and what we put in HEAD won't matter (since > > nobody will be able to write into refs/ anyway). > > I wonder if it would help to take the "looser repository detection" > code alone and have it in a release, way before the rest of the > reftable topic is ready. Then by the time a repository created by a > reftable-enabled Git appears on people's disks, all the older > versions of Git that are still in people's hands would at least know > that it is a repository supported by future Git that they themselves > do not know how to handle, stop repository discovery correctly and > refrain from damaging the repository with an extension unknown to > them?
Sure. I suspect that the reftable topic will take some time to get fully ready.
However, it would be good to have a definite plan for the layout now, because JGit (if you tell it to) is already creating repositories with the layout we're moving away from.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado