Re: [PATCH v3 06/10] trailer: spread usage of "trailer_block" language

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2024, 18:57 UTC
Message-ID: <xmqqil38ypuk.fsf@gitster.g>
In-Reply-To: <0a9a7438c3ff39f1434087bf3ed6a9865758c803.1706664145.git.gitgitgadget@gmail.com>

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> From: Linus Arver <linusa@google.com>
>
> Deprecate the "trailer_info" struct name and replace it with
> "trailer_block". The main reason is to help readability, because
> "trailer_info" on the surface sounds like it's about a single trailer
> when in reality it is a collection of contiguous lines, at least 25% of
> which are trailers.

Yup, "info" is usually a fairly meaningless word. At least "block" may imply it is a collection of trailers.

The naming would not matter as much to the API users, if the thing is now opaque, though.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.