Re: [PATCH v3 03/10] trailer: unify trailer formatting machinery

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2024, 17:48 UTC
Message-ID: <xmqqjzno13ev.fsf@gitster.g>
In-Reply-To: <owly1q9x2io6.fsf@fine.c.googlers.com>

Linus Arver <linusa@google.com> writes:

Show 10 quoted lines

> Josh Steadmon <steadmon@google.com> writes:
>
>> On 2024.01.31 01:22, Linus Arver via GitGitGadget wrote:
>>> This unification will allow us to delete the format_trailer_info() and
>>> print_tok_val() functions in the next patch. They are not deleted here
>>> in order to keep the diff small.
>>
>> Needs to be removed after squashing v2 patch 4 :)
>
> Oops. Will update in next reroll, thanks.

FWIW, by the way, having them in the same patch made it a lot easier to compare what the original did (with these removed functions) and what the updated code would do. When a change is supposed to be a clean-up of an existing code without changing the behaviour, it helps to make the before and after versions visible in the patch.

Thanks.