Re: [PATCH v4 15/28] format_trailer_info(): avoid double-printing the separator
On Tue, Feb 6, 2024, at 06:12, Linus Arver via GitGitGadget wrote:
Show 12 quoted lines
> From: Linus Arver <linusa@google.com>
>
> Do not hardcode the printing of ": " as the separator and space (which
> can result in double-printing these characters); instead only
> print the separator and space if we cannot find any recognized separator
> somewhere in the key (yes, keys may have a trailing separator in it ---
> we will eventually fix this design but not now). Do so by copying the
> code out of print_tok_val(), and deleting the same function.
>
> The test suite passes again with this change.
>
> Signed-off-by: Linus Arver <linusa@google.com>
Nice find and a great commit message!
--
Kristoffer Haugsbakk