Re: [PATCH v4 15/28] format_trailer_info(): avoid double-printing the separator

From: Christian Couder <christian.couder@gmail.com>
Date: Feb 13, 2024, 17:25 UTC
Message-ID: <CAP8UFD0nmK4ZigW9LcWOr_POEX5LX7m+T=Jq9rK34YL5C6xatw@mail.gmail.com>
In-Reply-To: <owlyr0hgb7qg.fsf@fine.c.googlers.com>

On Tue, Feb 13, 2024 at 6:21 PM Linus Arver <linusa@google.com> wrote:

Show 5 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:

Show 7 quoted lines

> > Also I wonder why it was not possible to modify format_trailer_info()
> > like it is done in this patch before using it to replace
> > format_trailers().
>
> The artificial organization apparent in this patch was deliberate, in
> order to make it painfully obvious exactly what was being replaced and
> how. See https://lore.kernel.org/git/xmqqjzno13ev.fsf@gitster.g/

As for the previous patch, I would have thought that it would be better not to break the tests.