Re: [PATCH v4 27/28] trailer_set_*(): put out parameter at the end

From: Linus Arver <linusa@google.com>
Date: Feb 13, 2024, 18:14 UTC
Message-ID: <owly4jecb5a6.fsf@fine.c.googlers.com>
In-Reply-To: <CAP8UFD2-M20uuo4G8HykRL=1g9634wKUT9R6DBG6nmLBqGpxzw@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 12 quoted lines

> On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Linus Arver <linusa@google.com>
>>
>> The new trailer_config_set_*() functions which were introduced a few
>> patches ago put the out parameter (the variable being mutated) at the
>> end of the parameter list.
>>
>> Put the out parameter at the end for these functions for these existing
>
> s/for these functions for these/for the/

That wording is much better; will update.

>> trailer_set_*() functions for consistency. This also avoids confusion
>> for API users because otherwise these two sets of functions look rather
>> similar in <trailer.h> even though they have completely different out
>> parameters.