Re: [PATCH v4 10/28] format_trailer_info(): use trailer_item objects

From: Linus Arver <linusa@google.com>
Date: Feb 13, 2024, 16:35 UTC
Message-ID: <owly1q9gcof3.fsf@fine.c.googlers.com>
In-Reply-To: <xmqq34u1e22y.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 22 quoted lines

> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Linus Arver <linusa@google.com>
>>
>> This is another preparatory refactor to unify the trailer formatters.
>>
>> Make format_trailer_info() operate on trailer_item objects, not the raw
>> string array.
>>
>> This breaks t4205 and t6300. We will continue to make improvements until
>> the test suite passes again, ultimately renaming format_trailer_info()
>> to format_trailers(), at which point the unification of these formatters
>> will be complete.
>>
>> Signed-off-by: Linus Arver <linusa@google.com>
>> ---
>>  trailer.c | 21 ++++++++++-----------
>>  1 file changed, 10 insertions(+), 11 deletions(-)
>
> I would have expected a (tentative) flip from test_expect_success to
> test_expect_failure in the affected tests, to illustrate what behaviour
> change this step introduces and why.

Somehow, such a simple idea did not cross my mind (even though I admit I didn't like how I was breaking tests, albeit temporarily). Will update on next reroll.

> But the huge single step in the previous round broken out into
> smaller steps like this round makes them much easier to follow.

Great, I'm doing something right for once! ;)