Re: [PATCH v2 01/10] trailer: prepare to expose functions as part of API
On 2024.01.26 22:38, Linus Arver via GitGitGadget wrote:
Show 13 quoted lines
> From: Linus Arver <linusa@google.com>
>
> In the next patch, we will move "process_trailers" from trailer.c to
> builtin/interpret-trailers.c. That move will necessitate the growth of
> the trailer.h API, forcing us to expose some additional functions in
> trailer.h.
>
> Rename relevant functions so that they include the term "trailer" in
> their name, so that clients of the API will be able to easily identify
> them by their "trailer" moniker, just like all the other functions
> already exposed by trailer.h.
>
> The the opportunity to start putting trailer processions options (opts)
Nitpick: typo in the commit message.
s/The the opportunity/Take the opportunity/ ?
Show 10 quoted lines
> as the first parameter. This will be the pattern going forward in this
> series.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
> builtin/interpret-trailers.c | 4 ++--
> trailer.c | 26 +++++++++++++-------------
> trailer.h | 6 +++---
> 3 files changed, 18 insertions(+), 18 deletions(-)