Re: [PATCH v4 23/28] trailer: add new helper functions to API
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 12, 2024, 23:39 UTC
- Message-ID
- <CAP8UFD0XjHtwB55XDajJia994TmUwub4L73QxhCQ8yTXc8++Ww@mail.gmail.com>
- In-Reply-To
- <3bfe4809ecbc5aa0ea52daee7684289398cb88d4.1707196348.git.gitgitgadget@gmail.com>
On Tue, Feb 6, 2024 at 6:12 AM Linus Arver via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 14 quoted lines
> > From: Linus Arver <linusa@google.com> > > This is a preparatory refactor for deprecating "new_trailer_item" from > the API (which will let us deprecate > parse_trailers_from_command_line_args()). > > Expose new helper functions from the API, because we'll be calling them > from interpret-trailers.c soon when we move > parse_trailers_from_command_line_args() there. > > Move free_new_trailers() from the builtin to trailer.c because later on > we will adjust it to free arg_item structs, which are private to > trailer.c.
This patch seems to be also doing too much.