Re: [PATCH 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 4, 2016, 11:05 UTC
- Message-ID
- <alpine.DEB.2.20.1605041304050.9313@virtualbox>
- In-Reply-To
- <CAP8UFD1+kEwFhAoveOTYt8NEOK=98W-00nNF+Yoe6kQAYJa6SQ@mail.gmail.com>
Hi Christian,
On Wed, 4 May 2016, Christian Couder wrote:
Show 9 quoted lines
> On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine <sunshine@sunshineco.com> wrote: > > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote: > >> bisect--helper: use OPT_CMDMODE instead of OPT_BOOL > > > > This subject is too low-level, talking about implementation details, > > whereas it should be giving a high-level summary of the change. > > When a patch is all about a low level detail, I think it is good to > talk about the detail in the subject.
Well, this is not the case here. The intent of this commit is to prepare for other command modes.
So... why not just say "bisect--helper: prepare for modes other than 'next-all'"?
Ciao, Dscho