Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: May 25, 2016, 05:13 UTC
Message-ID: <CAFZEwPPf6sRnJDyW9hLjEYa-=6Bjw_rWss9T5D_n_aXUX=TcGA@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1605250657250.4449@virtualbox>

Hey Johannes,

On Wed, May 25, 2016 at 10:34 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> Hi Pranit,
>
> I think this patch series is now in a fine shape. Just one minor nit:

Thanks!

Show 15 quoted lines

> On Tue, 24 May 2016, Pranit Bauva wrote:
>
>> +             OPT_CMDMODE(0, "check-term-format", &cmdmode,
>> +                      N_("check format of the term"), CHECK_TERM_FMT),
>
> Just like with cmd_mode and CMD_MODE, it would be more consistent to use
> CHECK_TERM_FORMAT (instead of abbreviating it) when the option is already
> spelled --check-term-format and the function name is check_term_format.
>
> It not only causes the eyes to stumble less, being consistent in naming
> causes less typos and also makes it easier to dig into the source code
> (think: `git grep -i check.name.format`).
>
> Not a big thing, but if you re-roll for any other reason, it would be good
> to make the naming consistent, too.

Sure I would include this in a re-roll. Anywhich ways it will really not make a big difference because after some time, "git grep -i check.term.format" wouldn't return anything except for the method name. Other occurrences would be vanished.

Regards, Pranit Bauva

> Ciao,
> Johannes