Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Jun 17, 2016, 12:48 UTC
- Message-ID
- <CAFZEwPNJLk3Y2KQopsc6AC4-LHUeam-ts5sHn4qdhbKM8UWiGA@mail.gmail.com>
- In-Reply-To
- <B8F28BE0-B43A-489F-9BCC-B40712C450D3@gmail.com>
Hey Lars, Hope you enjoyed your vacations. :)
On Thu, Jun 16, 2016 at 12:40 PM, Lars Schneider <larsxschneider@gmail.com> wrote:
Show 24 quoted lines
> > On 24 May 2016, at 09:21, Pranit Bauva <pranit.bauva@gmail.com> wrote: > >> Reimplement the `check_term_format` shell function in C and add >> a `--check-term-format` subcommand to `git bisect--helper` to call it >> from git-bisect.sh >> >> Using `--check-term-format` subcommand is a temporary measure to port >> shell function to C so as to use the existing test suite. As more >> functions are ported, this subcommand will be retired and will >> be called by some other method/subcommand. For eg. In conversion of >> write_terms() of git-bisect.sh, the subcommand will be removed and >> instead check_term_format() will be called in its C implementation while >> a new subcommand will be introduced for write_terms(). >> >> Helped-by: Johannes Schindelein <Johannes.Schindelein@gmx.de> >> Mentored-by: Lars Schneider <larsxschneider@gmail.com> >> Mentored-by: Christian Couder <chriscool@tuxfamily.org> > > Hi Pranit, > > please drop my Mentored-by until I contribute something > useful. I feel bad being mentioned in the same way as > Christian although he does all the work.
Sure! I will looking forward for you to comment more!
Regards, Pranit Bauva