Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Jun 16, 2016, 07:10 UTC
- Message-ID
- <B8F28BE0-B43A-489F-9BCC-B40712C450D3@gmail.com>
- In-Reply-To
- <20160524072124.2945-3-pranit.bauva@gmail.com>
On 24 May 2016, at 09:21, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 15 quoted lines
> Reimplement the `check_term_format` shell function in C and add > a `--check-term-format` subcommand to `git bisect--helper` to call it > from git-bisect.sh > > Using `--check-term-format` subcommand is a temporary measure to port > shell function to C so as to use the existing test suite. As more > functions are ported, this subcommand will be retired and will > be called by some other method/subcommand. For eg. In conversion of > write_terms() of git-bisect.sh, the subcommand will be removed and > instead check_term_format() will be called in its C implementation while > a new subcommand will be introduced for write_terms(). > > Helped-by: Johannes Schindelein <Johannes.Schindelein@gmx.de> > Mentored-by: Lars Schneider <larsxschneider@gmail.com> > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Hi Pranit,
please drop my Mentored-by until I contribute something useful. I feel bad being mentioned in the same way as Christian although he does all the work.
Thanks, Lars
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> > ---