Re: [PATCH 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- May 4, 2016, 12:04 UTC
- Message-ID
- <CAFZEwPMOuDB-SrNGPp3D1yBSVLaEvbJujKa7PVKOBt8PqUvk0w@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.20.1605041304050.9313@virtualbox>
On Wed, May 4, 2016 at 4:35 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 19 quoted lines
> Hi Christian, > > On Wed, 4 May 2016, Christian Couder wrote: > >> On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine <sunshine@sunshineco.com> wrote: >> > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote: >> >> bisect--helper: use OPT_CMDMODE instead of OPT_BOOL >> > >> > This subject is too low-level, talking about implementation details, >> > whereas it should be giving a high-level summary of the change. >> >> When a patch is all about a low level detail, I think it is good to >> talk about the detail in the subject. > > Well, this is not the case here. The intent of this commit is to prepare > for other command modes. > > So... why not just say "bisect--helper: prepare for modes other than > 'next-all'"?
Sounds nice!
> Ciao, > Dscho
Thanks, Pranit Bauva