Re: [PATCH v2] bisect--helper: convert a function in shell to C

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 22, 2016, 15:11 UTC
Message-ID: <alpine.DEB.2.20.1603221610370.4690@virtualbox>
In-Reply-To: <alpine.DEB.2.20.1603221552100.4690@virtualbox>

Hi,

On Tue, 22 Mar 2016, Johannes Schindelin wrote:

Show 15 quoted lines

> On Tue, 22 Mar 2016, Pranit Bauva wrote:
> 
> > +	if (!strcmp(term, "bad") || !strcmp(term, "new"))
> > +		if(strcmp(revision, "bad"))
> > +			die("can't change the meaning of term '%s'", term);
> > +
> > +	if (!strcmp(term, "good") || !strcmp(term, "old"))
> > +		if (strcmp(revision, "good"))
> > +			die("can't change the meaning of term '%s'", term);
> 
> These two can be combined. Actually, these *four* can easily be combined:
> 
> 	if ((one_of(term, "bad", "new", NULL) && strcmp(orig, "bad")) ||
> 	    (one_of(term, "good", "old", NULL) && strcmp(orig, "good")))
> 		die("can't change the meaning of term '%s'", term);

Completely forgot to mention: This conversion skipped the comment

	# In theory, nothing prevents swapping
	# completely good and bad, but this situation
	# could be confusing and hasn't been tested
	# enough. Forbid it for now.

Let's port that comment over, too?

Ciao, Johannes