Re: [PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: May 24, 2016, 17:39 UTC
Message-ID: <xmqqbn3v5p9w.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD1WZ=5e9u5awrHDG-vhMR5dw5NNY_yVEkp2o0rgx59nnQ@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

Show 18 quoted lines

>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index 7d7965d..cd39bd0 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -210,7 +210,7 @@ bisect_start() {
>>         eval "$eval true" &&
>>         if test $must_write_terms -eq 1
>>         then
>> -               write_terms "$TERM_BAD" "$TERM_GOOD"
>> +               git bisect--helper --write-terms "$TERM_BAD" "$TERM_GOOD" || exit
>
> This `|| exit` is not needed because...
>
>>         fi &&
>>         echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
>
> ... there is an `|| exit` on the line above (which is chained using
> `&&` to the previous lines).

Could you please trim parts that you are not commenting on when quoting? Thanks.