Re: [PATCH 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 4, 2016, 14:56 UTC
- Message-ID
- <alpine.DEB.2.20.1605041654300.9313@virtualbox>
- In-Reply-To
- <CAP8UFD0QeZqLaPwFe5wo0n1fdtSppJmYdUDc+Yo1duH1uyWbpw@mail.gmail.com>
Hi Christian,
On Wed, 4 May 2016, Christian Couder wrote:
> My intent was to try to show that there is some important value to make > the subject close to the "low level" thing the patch actually does.
I disagree. The place to describe low-level details that are not immediately obvious from the patch is the commit message. Way, way down on the bottom.
The commit message should start with a subject that gives me a good clue why this is a good change. A low-level detail won't do that very often.
Ciao, Johannes