Re: [PATCH v2] bisect--helper: convert a function in shell to C

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 23, 2016, 11:22 UTC
Message-ID: <alpine.DEB.2.20.1603231220560.4690@virtualbox>
In-Reply-To: <CAFZEwPNg8-X5dsBbMfg5ni1XpOVekRd13y-zgwYJpX0fCwg3Ug@mail.gmail.com>

Hi Pranit,

On Tue, 22 Mar 2016, Pranit Bauva wrote:

Show 9 quoted lines

> I did run the tests. They produce the same results as they did before.
> To ease review I will next time include these the output of the tests
> in the commented section.
> 
> t6002-rev-list-bisect.sh : http://paste.ubuntu.com/15473728/
> t6030-bisect-porcelain.sh : http://paste.ubuntu.com/15473734/
> t6041-bisect-submodule.sh : http://paste.ubuntu.com/15473743/
> 
> Is there any other test I would need to run?

Oh, I just meant to point out that you need to make sure that the entire test suite passes after your patch series (and ideally, after every patch, that is at least what I frequently test before sending out patch series).

There is not really a need to mention that you ran the test suite. There is only a need to run it ;-)

Ciao, Johannes