Re: [PATCH v6 2/3] bisect: rewrite `check_term_format` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2016, 18:01 UTC
Message-ID: <xmqq60uhalcp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAFZEwPP+w4BOU+jKSRqGLBx-1f9JtZCq5bj-kkg4-Yw_omeswg@mail.gmail.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

> Not just that, it would also be fundamentally more correct as there is
> a difference between " !strcmp("good") " and " strcmp("bad") ".

Not really. As long as you are in tight control of the callers, because we'd never call $2 with anything other than good and bad in the original, there is no deep fundmental difference between them.

It is just "test bad != $2" makes it more clear that we are checking if $2 is not 'bad', but strcmp(orig_term, "bad") doesn't do so as strongly as that.

> Will do this change in a separate patch after the dust settles.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.