From: Pranit Bauva Date: Fri, 17 Jun 2016 12:48:48 GMT Subject: Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C Message-ID: In-Reply-To: Hey Lars, Hope you enjoyed your vacations. :) On Thu, Jun 16, 2016 at 12:40 PM, Lars Schneider wrote: > > On 24 May 2016, at 09:21, Pranit Bauva wrote: > >> Reimplement the `check_term_format` shell function in C and add >> a `--check-term-format` subcommand to `git bisect--helper` to call it >> from git-bisect.sh >> >> Using `--check-term-format` subcommand is a temporary measure to port >> shell function to C so as to use the existing test suite. As more >> functions are ported, this subcommand will be retired and will >> be called by some other method/subcommand. For eg. In conversion of >> write_terms() of git-bisect.sh, the subcommand will be removed and >> instead check_term_format() will be called in its C implementation while >> a new subcommand will be introduced for write_terms(). >> >> Helped-by: Johannes Schindelein >> Mentored-by: Lars Schneider >> Mentored-by: Christian Couder > > Hi Pranit, > > please drop my Mentored-by until I contribute something > useful. I feel bad being mentioned in the same way as > Christian although he does all the work. Sure! I will looking forward for you to comment more! Regards, Pranit Bauva