Re: [PATCH v6 0/6] [GSoC] bitmap: integrate a lookup table extension to the bitmap format

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 22, 2022, 14:48 UTC
Message-ID: <YwOXIE8K0GJRLuDT@nand.local>
In-Reply-To: <80852679-rsso-rp45-q328-99n36q0639sq@tzk.qr>

On Mon, Aug 22, 2022 at 04:42:49PM +0200, Johannes Schindelin wrote:

> Taylor contributed <cover.1660944574.git.me@ttaylorr.com> to address the
> bug. While he seems grateful for my help, I am honestly puzzled because I
> lack too much knowledge about the code to have been of assistance in any
> meaningful way.

I was grateful ;-). Your contributions were quite helpful, especially making the bug more easily reproducible (doubly so since that test *could* have failed on master since its introduction, but didn't).

Pinning down some of the effects of the bug and documenting those were helpful, too.

> My participation in this thread should not be mistaken for a review: I am
> woefully unfamiliar with the bitmap design (let alone code) and would
> therefore not _dare_ to offer anything that I would claim is a code
> review.

Reviewing Abhradeep's patches are on my list of things to get to, hopefully today. I had hoped to get to it last week after getting back from vacation, but was stymied by the aforementioned bug.

Thanks, Taylor