Re: [PATCH v3 2/6] pack-bitmap-write.c: write lookup table extension

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 26, 2022, 00:34 UTC
Message-ID: <Yt82kskifigs9kAf@nand.local>
In-Reply-To: <CAPOJW5yH=Xywqos2tPS4Cn7dAdDqymPVbb6tn_XoAz0ofsACAA@mail.gmail.com>

On Sat, Jul 16, 2022 at 05:20:57PM +0530, Abhradeep Chakraborty wrote:

Show 5 quoted lines

> I think the comment I added is not that good. The following might be better -
>
>     At the end of this sort table[j] = i means that the i'th
>     bitmap corresponds to j'th bitmapped commit (among the selected commits)
>     in lex order of OIDs.

Makes sense, I think that version of the comment is more helpful. I appreciate your attention to detail on getting these things right!

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.