Re: [PATCH v3 5/6] bitmap-lookup-table: add performance tests for lookup table

>
> Having "lookup=false" in this test definitely helps visually
> differentiate which tests have a bitmap with and without the lookup
> table.
>
> I think we should take a slightly different approach for these
> performance tests. I think the first change to the t/perf tests in this
> series should only enable `pack.writeReverseIndex`. That patch would be
> a good place to highlight the benefit of enabling the on-disk reverse
> index by showing a before and after of running p5310 before and after
> that commit.
>
> Then the patch after that should look like this one, which runs the
> suite with and without the lookup table. That should give us a sense of:
>
>   - bitmaps without a lookup table or reverse index
>   - bitmaps without a lookup table, but with a reverse index
>   - bitamps with a reverse index and a lookup table
>
> ...which I think are the most interesting combinations (I wouldn't
> expect many or any users to have lookup tables enabled without reverse
> indexes).
>
> I think that would allow us to drop the last patch in this version of
> the series. But I'm definitely open to other testing strategies for the
> performance tests (including this one!) if you have different thoughts
> about what the best way to go about this is.