Re: [PATCH v2 5/6] bitmap-lookup-table: add performance tests for lookup table

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Jun 28, 2022, 07:58 UTC
Message-ID: <20220628075843.19170-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <Yrom04Go0tCAZWT8@nand.local>

Taylor Blau <me@ttaylorr.com> wrote:

> I think this "create tags" step can happen outside of the test_bitmap()
> function, since it should only need to be done once, right?

Yeah, I also think the same. That's why I tried to not include in the Function but for some reason, one test is failing -

  perf 24 - rev-list with tag negated via --not --all (objects):
  running: 
  		git rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null
	
  fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.
  Use '--' to separate paths from revisions, like this:
  'git <command> [<revision>...] -- [<file>...]'
  not ok 24 - rev-list with tag negated via --not --all (objects)

One thing to note here is that the first `test_bitmap` call always Passes. But the second `test_bitmap` call fails due to above error. It throws error irrespective of any parameters for second `test_bitmap`.

If I put it inside the function it doesn't throw any error!

For this reason, I put it into the function. Do you have any idea why this happend?

Show 6 quoted lines

> And I think these two tests could be combined, since this could just
> become:
>
>    git -c pack.writeBitmapLookupTable "$enabled" repack -ad
>
> right?

Yeah, sure.

> There is some funky spacing going on here, at least in my email client.
> Could you double check that tabs are used consistently here?

This is due to my editor's spacing issues. All seems fine when I look at it in my editor. But actually it is not. Fixing it.

Thanks :)