Re: [PATCH v5 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 16, 2022, 18:47 UTC
Message-ID: <YvvmNnjQVkzMTgVs@nand.local>
In-Reply-To: <68r08n47-9o07-351s-710q-786q69429q86@tzk.qr>

On Wed, Aug 10, 2022 at 11:09:40AM +0200, Johannes Schindelin wrote:

Show 17 quoted lines

> Hi Abhradeep,
>
> On Tue, 9 Aug 2022, Abhradeep Chakraborty wrote:
>
> >  I noticed in the 'setup partial bitmaps' test case that if we comment
> > out the line `git repack &&` , it runs successfully.
> >
> >     test_expect_success 'setup partial bitmaps' '
> >         test_commit packed &&
> >         # git repack &&
> >         test_commit loose &&
> >         git multi-pack-index write --bitmap 2>err &&
> >         ...
> >     '
>
> That's interesting. Are the `.bitmap` and `.midx` files updated as part of
> that `repack`?

They aren't. You can cause a MIDX / bitmap to be updated during `git repack` provided that the flags `--write-midx` and `--write-bitmap-index` are given to `repack`.

But the point of that `git repack` in this test case specifically is to ensure that the commit generated on the previous line is included in a new pack, and that that pack makes its way into the MIDX.

So removing that invocation of `git repack` means that the set of packs would be unchanged, and the `git multi-pack-index write --bitmap` would be a noop. That should rule out the theory that the existing MIDX is broken, since without the `git repack`, we'd be using that MIDX in subsequent tests (which pass).

Thanks, Taylor