Re: [PATCH v2 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 27, 2022, 17:49 UTC
Message-ID: <Yrntsj06L1G0joIz@nand.local>
In-Reply-To: <20220627174230.16253-1-chakrabortyabhradeep79@gmail.com>

On Mon, Jun 27, 2022 at 11:12:30PM +0530, Abhradeep Chakraborty wrote:

Show 8 quoted lines

> Derrick Stolee <derrickstolee@github.com> wrote:
>
> > I wonder if it makes sense to have it default to 'false' for now, but to
> > change that default after the feature has been shipped and running in
> > production for a while.
>
> I do not have any opinion. If most reviewers agree on it, I will surely
> Set it to false.

I think it's definitely a safe approach. I don't have a huge concern about enabling it earlier, but I don't think we're in a huge rush to add a new feature here, either.

So I'd be fine to ship this with the default being disabled (IOW, *not* writing the lookup table). That should give us a window where we can shake out whatever bugs there are, as is often the case when working with the bitmap code ;).

Thanks, Taylor