Re: [PATCH v2 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Jun 27, 2022, 18:39 UTC
Message-ID: <20220627183924.16369-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <YrntSpG5asIPNdZz@nand.local>

Taylor Blau <me@ttaylorr.com> wrote:

> Probably both of them should take into account their separate
> configuration values, but cleaning up the hashcache one can be done
> separately outside of this series.

Actually, it does respect the `pack.writebitmaplookuptable` config. As pack.writebitmaplookuptable is by default true (for this patch Series), this line enables it by default. If `pack.writebitmaplookuptable` Set to false, the proposed change in the `git_multi_pack_index_write_config` function disables this flag.

> This region may make more sense to include in the previous commit,
> though I don't have a strong feeling about it.

Ok. Will move it to the previous patch.

Thanks :)