Re: [PATCH 1/6] Documentation/technical: describe bitmap lookup table extension
- From
Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
- Date
- Jun 22, 2022, 16:45 UTC
- Message-ID
- <20220622164523.46256-1-chakrabortyabhradeep79@gmail.com>
- In-Reply-To
- <YrNDZMixyt8xNAvS@nand.local>
Taylor Blau <me@ttaylorr.com> wrote:
Show 11 quoted lines
> It should be negligible relative to everything else, I would imagine. > The function that converts an index position into an object ID is > `nth_packed_object_id()`. > > > I still have a feeling that there is some way to get rid of this > > list of commit ids. But at the same time, I do not want to add > > extra computation to the code. > > I'm hoping that the additional complexity is minor. And if we can save > some extra bytes that aren't necessary in the first place without > compromising on performance, I think that's worthwhile to do.
Ok. I will look into it then.
Most of the reviews has been addressed. Hope I will be able to submit it soon.
Thanks :)