[PATCH v2 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: Jun 27, 2022, 17:42 UTC
Message-ID: <20220627174230.16253-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <05edd01a-8b6f-b25d-0cd1-b1a46ca7c219@github.com>

Derrick Stolee <derrickstolee@github.com> wrote:

> I wonder if it makes sense to have it default to 'false' for now, but to
> change that default after the feature has been shipped and running in
> production for a while.

I do not have any opinion. If most reviewers agree on it, I will surely Set it to false.

> I think you should either use "Git" when talking about the software
> generally, OR use "`git repack --write-bitmap-index` will include..."

Ohh, yeah! Thanks for pointing out.

Show 5 quoted lines

> s/which/that/
>
> (I'm pretty sure that "that" is better. We're trying to restrict the set
> of repositories we are talking about, not implying that all repositories
> have this property.)

Ok.

> These lines seem misplaced. Maybe they were meant for the previous
> patch?

I mainly used it for testing purpose. That's why I included it in This patch. But I got your point and will move it to the previous patch.

Thanks :)