Re: [PATCH v2 5/6] bitmap-lookup-table: add performance tests for lookup table

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 29, 2022, 20:40 UTC
Message-ID: <Yry40c0lqOoU8p4G@nand.local>
In-Reply-To: <20220628075843.19170-1-chakrabortyabhradeep79@gmail.com>

On Tue, Jun 28, 2022 at 01:28:43PM +0530, Abhradeep Chakraborty wrote:

Show 25 quoted lines

> Taylor Blau <me@ttaylorr.com> wrote:
>
> > I think this "create tags" step can happen outside of the test_bitmap()
> > function, since it should only need to be done once, right?
>
> Yeah, I also think the same. That's why I tried to not include in the
> Function but for some reason, one test is failing -
>
>   perf 24 - rev-list with tag negated via --not --all (objects):
>   running:
>   		git rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null
>
>   fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.
>   Use '--' to separate paths from revisions, like this:
>   'git <command> [<revision>...] -- [<file>...]'
>   not ok 24 - rev-list with tag negated via --not --all (objects)
>
> One thing to note here is that the first `test_bitmap` call always
> Passes. But the second `test_bitmap` call fails due to above error.
> It throws error irrespective of any parameters for second `test_bitmap`.
>
> If I put it inside the function it doesn't throw any error!
>
> For this reason, I put it into the function. Do you have any idea
> why this happend?

I think that it's because we delete all of the refs in the test that creates a partial bitmap state. So anything that relies on perf-tag existing after that test runs will definitely not work :).

My original suggestion was misguided there, unless we wanted to make the aforementioned test (the one that creates the partial bitmap state) restore the ref state after it finishes running, but I don't think that's worthwhile.

Thanks, Taylor