Re: [PATCH v3 2/6] pack-bitmap-write.c: write lookup table extension

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 14, 2022, 23:26 UTC
Message-ID: <YtCmESpC7DmNhAcm@nand.local>
In-Reply-To: <5e9b985e39b0b9edee7af55dd8b0698a20062cf7.1656924376.git.gitgitgadget@gmail.com>

On Mon, Jul 04, 2022 at 08:46:12AM +0000, Abhradeep Chakraborty via GitGitGadget wrote:

> From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
>
> The bitmap lookup table extension was documented by an earlier
> change, but Git does not yet know how to write that extension.

This and the first patch both look in great shape to me. I haven't had a chance to take a close look through the remaining four patches, but I anticipate that they are in similarly-good shape.

I'll have some more time to finish reviewing this tomorrow morning. I want to give it a closer inspection this round to make sure that everything is correct (and that we're assembling the various orderings the right way by stepping through it in a debugger, etc., etc.).

Thanks for all of your patience :-).

Thanks, Taylor