Re: [PATCH v2 07/11] reftable: use `uint16_t` to track restart interval

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2024, 22:42 UTC
Message-ID: <xmqqv83hcp0i.fsf@gitster.g>
In-Reply-To: <05e8d1df2d9921426b803d71b22ba3dba188836c.1715336798.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> The restart interval can at most be `UINT16_MAX` as specified in the
> technical documentation of the reftable format. Furthermore, it cannot
> ever be negative. Regardless of that we use an `int` to track the
> restart interval.
>
> Change the type to use an `uint16_t` instead.

Not wrong per-se, but this one is more or less a Meh, as we know we do not work on 16-bit platforms anyway.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.