Re: [PATCH v3 02/11] reftable: pass opts as constant pointer

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 17, 2024, 08:02 UTC
Message-ID: <CAOLa=ZTGdM8u7PyBGis7XZvrrWLLpQXMuTdAQjYGy+0JdR7CRQ@mail.gmail.com>
In-Reply-To: <f1c9914a77ab9bfe27a62e324cc3eb388f4118d9.1715587849.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 13 quoted lines

> We sometimes pass the refatble write options as value and sometimes as a
> pointer. This is quite confusing and makes the reader wonder whether the
> options get modified sometimes.
>
> In fact, `reftable_new_writer()` does cause the caller-provided options
> to get updated when some values aren't set up. This is quite unexpected,
> but didn't cause any harm until now.
>
> Adapt the code so that we do not modify the caller-provided values
> anymore. While at it, refactor the code to code to consistently pass the
> options as a constant pointer to clarify that the caller-provided opts
> will not ever get modified.
>

So from v2, we changed this from passing the value to passing the address. Mostly, we're trying to stay consistent and have to pick either, so this makes more sense since we're passing around big structs.