Re: [PATCH v2 07/11] reftable: use `uint16_t` to track restart interval

From: Patrick Steinhardt <ps@pks.im>
Date: May 14, 2024, 04:54 UTC
Message-ID: <ZkLulczNVfU3zCcE@tanuki>
In-Reply-To: <xmqqv83hcp0i.fsf@gitster.g>

On Mon, May 13, 2024 at 03:42:37PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > The restart interval can at most be `UINT16_MAX` as specified in the
> > technical documentation of the reftable format. Furthermore, it cannot
> > ever be negative. Regardless of that we use an `int` to track the
> > restart interval.
> >
> > Change the type to use an `uint16_t` instead.
> 
> Not wrong per-se, but this one is more or less a Meh, as we know we
> do not work on 16-bit platforms anyway.

Yeah, my intent isn't really "platform portability". It's rather that I think that an `uint16_t` documents the accepted range of values much better than `int` does.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.