Re: [PATCH 00/11] reftable: expose write options as config
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- May 10, 2024, 10:00 UTC
- Message-ID
- <CAOLa=ZTz5k8Ge8Ba1f0AUXE1NRE1sO_g5zrtTeYcthKP9VVeCw@mail.gmail.com>
- In-Reply-To
- <cover.1714630191.git.ps@pks.im>
Hello Patrick,
Patrick Steinhardt <ps@pks.im> writes:
Show 31 quoted lines
> Hi, > > the reftable format has some flexibility with regards to how exactly it > writes the respective tables: > > - The block size allows you to control how large each block is > supposed to be. The bigger the block, the more records you can fit > into it. > > - Restart intervals control how often a restart point is written that > breaks prefix compression. The lower the interval, the less disk > space savings you get. > > - Object indices can be enabled or disabled. These are optional and > Git doesn't use them right now, so disabling them may be a sensible > thing to do if you want to save some disk space. > > - The geometric factor controls when we compact tables during auto > compaction. > > This patch series exposes all of these via a new set of configs so that > they can be tweaked by the user as-needed. It's not expected that those > are really of much importance for the "normal" user -- the defaults > should be good enough. But for edge cases (huge repos with millions of > refs) and for hosting providers these knobs can be helpful. > > This patch series applies on top of d4cc1ec35f (Start the 2.46 cycle, > 2024-04-30). > > Patrick >
I'v gone through the commits and apart from a few small comments, I think it looks great already.
Thanks, Karthik