Re: [PATCH v3 05/11] reftable/dump: support dumping a table's block structure

From: Patrick Steinhardt <ps@pks.im>
Date: May 22, 2024, 07:19 UTC
Message-ID: <Zk2chD_uAScoQJB4@tanuki>
In-Reply-To: <t7vrnm4kgyu5kl6evrfm6pvhwffwi5tku45tjds7mz7rpip2hz@77zv3givo7pp>

On Tue, May 21, 2024 at 06:35:13PM -0500, Justin Tobler wrote:

Show 24 quoted lines

> On 24/05/13 10:18AM, Patrick Steinhardt wrote:
> > +int reftable_reader_print_blocks(const char *tablename)
> > +{
> > +	struct {
> > +		const char *name;
> > +		int type;
> > +	} sections[] = {
> > +		{
> > +			.name = "ref",
> > +			.type = BLOCK_TYPE_REF,
> > +		},
> > +		{
> > +			.name = "obj",
> > +			.type = BLOCK_TYPE_OBJ,
> > +		},
> > +		{
> > +			.name = "log",
> > +			.type = BLOCK_TYPE_LOG,
> > +		},
> > +	};
> 
> I noticed that we are not including all the block types. Would we ever
> want to also be able to dump index blocks? Or would they not be useful
> in this context?

Maybe. It wasn't really necessary to include index blocks in this context as I was already able to extract all relevant information without them. So I decided to skip them. We may iterate on this in the future as required.

Patrick