Re: [PATCH v3 00/11] reftable: expose write options as config
- From
Justin Tobler <jltobler@gmail.com>
- Date
- May 21, 2024, 23:54 UTC
- Message-ID
- <akuvjnvz43fzcggytbkyjhq6htljucucmexecel3h4eooqrcca@j5umyot7clwe>
- In-Reply-To
- <cover.1715587849.git.ps@pks.im>
On 24/05/13 10:17AM, Patrick Steinhardt wrote:
Show 18 quoted lines
> Hi, > > this is the third version of my patch series that exposes several write > options of the reftable library via Git configs. > > Changes compared to v2: > > - Adapted patch 2 such that we now pass options as const pointers > instead of by value. > > - Removed a confusing sentence in the documentation of the restart > points in patch 8. > > Other than that I decided to rebase this on top of the current "master" > branch at 0f3415f1f8 (The second batch, 2024-05-08). This is because the > revamped patch 2 would cause new conflicts with 485c63cf5c (reftable: > remove name checks, 2024-04-08) that didn't exist in v2 of this patch > series yet. Rebasing thus seemed like the more reasonable option.
Thanks Patrick! I reviewed this version and left a couple comments/questions, but nothing that would neccessitate a reroll. :)
-Justin