Re: [PATCH 11/11] refs/reftable: allow configuring geometric factor

From: Patrick Steinhardt <ps@pks.im>
Date: May 10, 2024, 10:13 UTC
Message-ID: <Zj3zYvr-o3hpnMGU@tanuki>
In-Reply-To: <CAOLa=ZSLx7fAo0kT5OR6wyjyTczDLOpcS82xGd195uWVs7JRFQ@mail.gmail.com>

On Fri, May 10, 2024 at 02:58:58AM -0700, Karthik Nayak wrote:

Show 24 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Allow configuring the geometric factor used by the auto-compaction
> > algorithm whenever a new table is appended to the stack of tables.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> > ---
> >  Documentation/config/reftable.txt | 10 ++++++++++
> >  refs/reftable-backend.c           |  5 +++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/Documentation/config/reftable.txt b/Documentation/config/reftable.txt
> > index 6e4466f3c5..1c381dda04 100644
> > --- a/Documentation/config/reftable.txt
> > +++ b/Documentation/config/reftable.txt
> > @@ -37,3 +37,13 @@ reftable.indexObjects::
> >  	are a reverse mapping of object ID to the references pointing to them.
> >  +
> >  The default value is `true`.
> > +
> > +reftable.geometricFactor::
> > +	Whenever the reftable backend appends a new table to the table it
> 
> This doesn't read right, did you mean 's/to the table/,' perhaps?

This should rather be "to the stack,". Good catch.

Patrick