Re: [PATCH v3 05/11] reftable/dump: support dumping a table's block structure
- From
Justin Tobler <jltobler@gmail.com>
- Date
- May 21, 2024, 23:35 UTC
- Message-ID
- <t7vrnm4kgyu5kl6evrfm6pvhwffwi5tku45tjds7mz7rpip2hz@77zv3givo7pp>
- In-Reply-To
- <c4377180ef9c92a28fa71b1cde90d80d901c8710.1715587849.git.ps@pks.im>
On 24/05/13 10:18AM, Patrick Steinhardt wrote:
Show 19 quoted lines
> +int reftable_reader_print_blocks(const char *tablename)
> +{
> + struct {
> + const char *name;
> + int type;
> + } sections[] = {
> + {
> + .name = "ref",
> + .type = BLOCK_TYPE_REF,
> + },
> + {
> + .name = "obj",
> + .type = BLOCK_TYPE_OBJ,
> + },
> + {
> + .name = "log",
> + .type = BLOCK_TYPE_LOG,
> + },
> + };I noticed that we are not including all the block types. Would we ever want to also be able to dump index blocks? Or would they not be useful in this context?
-Justin