Re: [PATCH v3 06/11] refs/reftable: allow configuring block size
Patrick Steinhardt <ps@pks.im> writes:
Show 36 quoted lines
> Add a new option `reftable.blockSize` that allows the user to control
> the block size used by the reftable library.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> Documentation/config.txt | 2 +
> Documentation/config/reftable.txt | 14 ++++++
> refs/reftable-backend.c | 31 ++++++++++++-
> t/t0613-reftable-write-options.sh | 72 +++++++++++++++++++++++++++++++
> 4 files changed, 118 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/config/reftable.txt
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 6f649c997c..cbf0b99c44 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -498,6 +498,8 @@ include::config/rebase.txt[]
>
> include::config/receive.txt[]
>
> +include::config/reftable.txt[]
> +
> include::config/remote.txt[]
>
> include::config/remotes.txt[]
> diff --git a/Documentation/config/reftable.txt b/Documentation/config/reftable.txt
> new file mode 100644
> index 0000000000..fa7c4be014
> --- /dev/null
> +++ b/Documentation/config/reftable.txt
> @@ -0,0 +1,14 @@
> +reftable.blockSize::
> + The size in bytes used by the reftable backend when writing blocks.
> + The block size is determined by the writer, and does not have to be a
> + power of 2. The block size must be larger than the longest reference
> + name or log entry used in the repository, as references cannot span
Nit: s/as references cannot/as neither can/