From: Junio C Hamano Date: Mon, 13 May 2024 22:42:37 GMT Subject: Re: [PATCH v2 07/11] reftable: use `uint16_t` to track restart interval Message-ID: In-Reply-To: <05e8d1df2d9921426b803d71b22ba3dba188836c.1715336798.git.ps@pks.im> Patrick Steinhardt writes: > The restart interval can at most be `UINT16_MAX` as specified in the > technical documentation of the reftable format. Furthermore, it cannot > ever be negative. Regardless of that we use an `int` to track the > restart interval. > > Change the type to use an `uint16_t` instead. Not wrong per-se, but this one is more or less a Meh, as we know we do not work on 16-bit platforms anyway.