Re: [PATCH v2 08/11] refs/reftable: allow configuring restart interval

From: Patrick Steinhardt <ps@pks.im>
Date: May 13, 2024, 07:54 UTC
Message-ID: <ZkHHGtbI2oyxNlhV@tanuki>
In-Reply-To: <xmqq34qp2uud.fsf@gitster.g>

On Fri, May 10, 2024 at 02:57:46PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > +
> > +reftable.restartInterval::
> > +	The interval at which to create restart points. The reftable backend
> > +	determines the restart points at file creation. The process is
> > +	arbitrary, but every 16 or 64 records is recommended. Every 16 may be
> 
> It is unclear what exactly "The process is arbitrary, but" wants to
> say, especially the use of the noun "process".  The process the user
> uses to choose the inteval value is?  The default value chosen by us
> was arbitrary and out of thin air?

The latter is what I wanted to say, but I agree that it's hard to parse. And honestly, I don't even know how arbitrary it is, so I should probably not claim something like this in the first place.

> Just striking the whole sentence (or removing up to ", but" part and
> starting the sentence with "Every 16 or 64") may make the resulting
> paragraph easier to follow, I suspect.

Will do.

Patrick