Re: [PATCH v9 2/9] imap-send: add support for OAuth2.0 authentication

From: Junio C Hamano <gitster@pobox.com>
Date: May 30, 2025, 21:12 UTC
Message-ID: <xmqqfrglerbx.fsf@gitster.g>
In-Reply-To: <CAPig+cSFLF9de3i7RsG6j4wSGkRRhGgOGOovoFXm9U2+t=qC+g@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Not a proper review, just something I spotted several versions back
> but assumed that someone else -- providing a proper review -- would
> mention...

I suspect that we weren't ready to prifvide "a proper review" yet on this series at the coding style level, while the design at a bit higher level, like "should choice of openssl/curl be runtime?", was discussed.

Show 9 quoted lines

> On this project, multi-line comments are formatted like this:
>
>     /*
>      * Line 1
>      * Line 2
>      * ...
>      */
>
> The same observation applies to other parts of this patch, as well.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.