[PATCH v4 4/4] imap-send: fix memory leak in case auth_cram_md5 fails
- From
Aditya Garg <gargaditya08@live.com>
- Date
- May 23, 2025, 12:14 UTC
- Message-ID
- <PN3PR01MB95970C9374353E47060C8703B898A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
- In-Reply-To
- <PN3PR01MB9597C5BC8528C0E068DDDA18B899A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
This patch fixes a memory leak by running free(response) in case auth_cram_md5 fails.
Signed-off-by: Aditya Garg <gargaditya08@live.com> --- imap-send.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c index ad54aceb28..87abfd15f3 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1046,8 +1046,10 @@ static int auth_cram_md5(struct imap_store *ctx, const char *prompt) response = cram(prompt, ctx->cfg->user, ctx->cfg->pass); ret = socket_write(&ctx->imap->buf.sock, response, strlen(response)); - if (ret != strlen(response)) + if (ret != strlen(response)) { + free(response); return error("IMAP error: sending response failed"); + } free(response);
-- 2.43.0