Re: [PATCH v11 6/9] imap-send: fix minor mistakes in the logs

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2025, 00:42 UTC
Message-ID: <xmqq8qmbvurr.fsf@gitster.g>
In-Reply-To: <20250601083821.2440110-7-gargaditya08@live.com>

Aditya Garg <gargaditya08@live.com> writes:

Show 8 quoted lines

> Some minor mistakes have been found in the logs. Most of them include
> error messages starting with a capital letter, and ending with a period.
> Also, abbreviations like "IMAP" and "OK" should be in uppercase. Fix them.
>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  imap-send.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Quite honestly, I am not sure if this churn is worth it.

Unless we are moving to the same error reporting mechanism more prevalently used elsewhere in our codebase and consistenly use the error() function instead of calling fprintf().

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.