Re: [PATCH 1/2] imap-send: fix bug causing cfg->folder being set to NULL

> Upon setting up imap-send config file, I encountered the very first bug.
> An error showing "no imap store specified" was being displayed on the
> terminal. Upon investigating further, in static int git_imap_config,
> cfg->folder was being incorrectly set to NULL in case imap.user, imap.pass,
> imap.tunnel and imap.authmethod were defined, and the values that these configs
> intended to set were not being set at all. Because of this, git imap-send was
> basically not usable at all. The bug seems to be there for quite a while, and
> has not yet been detected, likely due to better options like git send-email
> being available.
>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
> diff --git a/imap-send.c b/imap-send.c
> @@ -1316,16 +1316,16 @@ static int git_imap_config(const char *var, const char *val,
>                 FREE_AND_NULL(cfg->folder);
>                 return git_config_string(&cfg->folder, var, val);
>         } else if (!strcmp("imap.user", var)) {
> -               FREE_AND_NULL(cfg->folder);
> +               FREE_AND_NULL(cfg->user);
>                 return git_config_string(&cfg->user, var, val);
>         } else if (!strcmp("imap.pass", var)) {
> -               FREE_AND_NULL(cfg->folder);
> +               FREE_AND_NULL(cfg->pass);
>                 return git_config_string(&cfg->pass, var, val);
>         } else if (!strcmp("imap.tunnel", var)) {
> -               FREE_AND_NULL(cfg->folder);
> +               FREE_AND_NULL(cfg->tunnel);
>                 return git_config_string(&cfg->tunnel, var, val);
>         } else if (!strcmp("imap.authmethod", var)) {
> -               FREE_AND_NULL(cfg->folder);
> +               FREE_AND_NULL(cfg->auth_method);
>                 return git_config_string(&cfg->auth_method, var, val);