Re: [PATCH v10 6/9] imap-send: fix numerous spelling and grammar mistakes in logs
On 01/06/25 12:58 pm, Eric Sunshine wrote:
Show 20 quoted lines
> On Sun, Jun 1, 2025 at 3:12 AM Aditya Garg <gargaditya08@live.com> wrote:
>> A lot of spelling and grammar mistakes were found in the logs shown to
>> the user while using imap-send. Most of them are lack of a full stop at
>> the end of a sentence and first word of a sentence not being capitalized.
>>
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>> ---
>> diff --git a/imap-send.c b/imap-send.c
>> @@ -249,9 +249,9 @@ static int verify_hostname(X509 *cert, const char *hostname)
>> if (!(subj = X509_get_subject_name(cert)))
>> - return error("cannot get certificate subject");
>> + return error("Cannot get certificate subject");
>> if ((len = X509_NAME_get_text_by_NID(subj, NID_commonName, cname, sizeof(cname))) < 0)
>> - return error("cannot get certificate common name");
>> + return error("Cannot get certificate common name");
>
> This patch generally seems to be taking the code in a direction
> opposite the rest of the project. Quoting from
> Documentation/CodingGuidelines:
> Lets drop this patch itself