Re: [PATCH 1/2] imap-send: fix bug causing cfg->folder being set to NULL

From: Ben Knoble <ben.knoble@gmail.com>
Date: May 24, 2025, 16:32 UTC
Message-ID: <C0BA42B3-D312-4575-A326-23E56D0EE8B5@gmail.com>
In-Reply-To: <E78F34A7-359E-4049-9780-30FC290DA7E2@gmail.com>

Show 12 quoted lines

> Le 24 mai 2025 à 12:28, Ben Knoble <ben.knoble@gmail.com> a écrit :
> 
> 
>> Le 22 mai 2025 à 14:26, Eric Sunshine <sunshine@sunshineco.com> a écrit :
>> 
>>   ret = socket_write(&ctx->imap->buf.sock, response, strlen(response));
>>   free(response);
>>   if (ret != strlen(response))
>>       return error("IMAP error: sending response failed");
>>   return 0;
> 
> Apologies if I missed something , but : strlen _after_ free?

Ah, others caught this already (and I hadn’t finished reading yet). I really need to find a way to queue up my messages and then go back after finishing a thread and edit before sending ;)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.